linux-kernel - Re: [PATCH v4 6/7] crypto: KEYS - add generic handlers to symmetric key type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <570D7495.7060801@intel.com>
Date:	Tue, 12 Apr 2016 15:20:05 -0700
From:	Tadeusz Struk <tadeusz.struk@...el.com>
To:	David Howells <dhowells@...hat.com>
Cc:	herbert@...dor.apana.org.au, smueller@...onox.de,
	linux-api@...r.kernel.org, marcel@...tmann.org,
	linux-kernel@...r.kernel.org, keyrings@...r.kernel.org,
	linux-crypto@...r.kernel.org, dwmw2@...radead.org,
	davem@...emloft.net
Subject: Re: [PATCH v4 6/7] crypto: KEYS - add generic handlers to symmetric
 key type

On 04/12/2016 03:10 PM, David Howells wrote:
>> +/**
>> > + * asymmetric_key_verify_signature - invoke verify signature operation on a key
>> > + *			             of the asymmetric subtype
>> > + * @key: key from the system keyring
>> > + * @sig: signature to verify
>> > + *
>> > + * return: 0 on success or errno on failure
>> > + */
>> > +int asymmetric_key_verify_signature(const struct key *key,
>> > +				    const struct public_key_signature *sig)
> This is duplicating what's in signature.c in the same directory.

Right, should I remove it? Is the asymmetric_type.c good place to put all the operation
handlers into?
Thanks,
-- 
TS