linux-kernel - Re: [PATCH 4/5] cpufreq: Loongson1: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160412052014.GR16238@vireshk-i7>
Date:	Tue, 12 Apr 2016 10:50:14 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Keguang Zhang <keguang.zhang@...il.com>
Cc:	linux-pm@...r.kernel.org, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH 4/5] cpufreq: Loongson1: Use devm_kzalloc() instead of
 global structure

On 11-04-16, 19:55, Keguang Zhang wrote:
> From: Kelvin Cheung <keguang.zhang@...il.com>
> 
> This patch uses devm_kzalloc() instead of global structure.
> 

Why are you doing this? The commit log should contain that.

> Signed-off-by: Kelvin Cheung <keguang.zhang@...il.com>
> ---
>  drivers/cpufreq/loongson1-cpufreq.c | 63 ++++++++++++++++++++-----------------
>  1 file changed, 35 insertions(+), 28 deletions(-)

I don't have any issues with you doing this, but I don't think that's
necessary to do.

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh