linux-kernel - Re: [PATCH 4.5 109/238] mtip32xx: Print exact time when an internal command is interrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160412062942.GC507@1wt.eu>
Date:	Tue, 12 Apr 2016 08:29:42 +0200
From:	Willy Tarreau <w@....eu>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Selvan Mani <smani@...ron.com>,
	Rajesh Kumar Sambandam <rsambandam@...ron.com>,
	Asai Thambi S P <asamymuthupa@...ron.com>,
	Jens Axboe <axboe@...com>
Subject: Re: [PATCH 4.5 109/238] mtip32xx: Print exact time when an internal
 command is interrupted

On Mon, Apr 11, 2016 at 09:06:13PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Apr 12, 2016 at 03:48:37AM +0100, Ben Hutchings wrote:
> > On Sun, 2016-04-10 at 11:34 -0700, Greg Kroah-Hartman wrote:
> > > 4.5-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Asai Thambi SP <asamymuthupa@...ron.com>
> > > 
> > > commit 5b7e0a8ac85e2dfd83830dc9e0b3554d153a37e3 upstream.
> > > 
> > > Print exact time when an internal command is interrupted.
> > [...]
> > 
> > There's no way that's important enough for stable.
> 
> I think one of the following patches needed it :(

Also in general I'd rather encourage maintainers to push their fixes
into stable than give up early and leave bogus code behind them considering
it's not their problem anymore once released. If someone cares enough to
fix code in -stable and introduces a regression, 1) we know how to revert
and 2) the same person will likely feel concerned by the issue and help
fix it.

Just my 2 cents,
Willy