lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Apr 2016 17:18:49 +0800 From: Guodong Xu <guodong.xu@...aro.org> To: Linus Walleij <linus.walleij@...aro.org> Cc: Xu Wei <xuwei5@...ilicon.com>, Mark Rutland <mark.rutland@....com>, Rob Herring <robh@...nel.org>, Grant Likely <grant.likely@...retlab.ca>, Arnd Bergmann <arnd.bergmann@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, XinWei Kong <kong.kongxinwei@...ilicon.com>, Zhong Kaihua <zhongkaihua@...wei.com> Subject: Re: [PATCH v2 04/16] arm64: dts: Add Hi6220 gpio configuration nodes On 4 April 2016 at 03:28, Linus Walleij <linus.walleij@...aro.org> wrote: > On Sat, Apr 2, 2016 at 11:29 AM, Guodong Xu <guodong.xu@...aro.org> wrote: > >> From: Zhong Kaihua <zhongkaihua@...wei.com> >> >> Add Hi6220 gpio configuration nodes >> >> Signed-off-by: Zhong Kaihua <zhongkaihua@...wei.com> >> Signed-off-by: Kong Xinwei <kong.kongxinwei@...ilicon.com> >> > > Get rid of that blank line. Will fix. Sorry missed that in v3. > >> Acked-by: Rob Herring <robh@...nel.org> >> Signed-off-by: Wei Xu <xuwei5@...ilicon.com> > >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -249,5 +249,264 @@ >> clocks = <&ao_ctrl 27>; >> clock-names = "apb_pclk"; >> }; >> + >> + gpio0: gpio@...11000 { >> + compatible = "arm,pl061", "arm,primecell"; >> + reg = <0x0 0xf8011000 0x0 0x1000>; >> + interrupts = <0 52 0x4>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + clocks = <&ao_ctrl 2>; >> + clock-names = "apb_pclk"; >> + status = "ok"; >> + }; > > This part with all GPIO controllers looks nice. > >> new file mode 100644 >> index 0000000..09242f0 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi >> @@ -0,0 +1,607 @@ >> +/ { >> + gpio_rstout_n:gpio_rstout_n { >> + gpios; >> + }; >> + gpio_pmu_peri_en:gpio_pmu_peri_en { >> + gpios; >> + }; >> + gpio_sysclk0_en:gpio_sysclk0_en { >> + gpios; >> + }; >> + gpio_jtag_tdo:gpio_jtag_tdo { >> + gpios; >> + }; >> + /* LCB: PWR_HOLD_GPIO0_0 */ >> + gpio_pwr_hold:gpio_pwr_hold { >> + gpios = <&gpio0 0 0>; >> + }; > > (...) > > I don't understand any stuff in this hikey-gpio.dtsi file. > > What does all this mean? > > If it has any practical use whatsoever then explain it in the > commit message, but right now it just looks like a big list > of placeholders with no use, but you can copy-paste them > into device nodes the day you need them? > > If they are unused, just drop this file please. I will drop this. Sorry missed this in v2. I will fix this in next version. -Guodong > > Yours, > Linus Walleij
Powered by blists - more mailing lists