linux-kernel - Re: [PATCH] writeback: Fix performance regression in wb_over_bg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160412111357.GS24661@htj.duckdns.org>
Date:	Tue, 12 Apr 2016 07:13:57 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Howard Cochran <hcochran@...nelspring.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	Howard Cochran <cochran@...mark.com>
Subject: Re: [PATCH] writeback: Fix performance regression in
 wb_over_bg_thresh()

On Thu, Mar 10, 2016 at 01:12:39AM -0500, Howard Cochran wrote:
> Commit 947e9762a8dd ("writeback: update wb_over_bg_thresh() to use
> wb_domain aware operations") unintentionally changed this function's
> meaning from "are there more dirty pages than the background writeback
> threshold" to "are there more dirty pages than the writeback threshold".
> The background writeback threshold is typically half of the writeback
> threshold, so this had the effect of raising the number of dirty pages
> required to cause a writeback worker to perform background writeout.
...
> Fixes: 947e9762a8dd ("writeback: update wb_over_bg_thresh() to use
>                      wb_domain aware operations")
> Signed-off-by: Howard Cochran <hcochran@...nelspring.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Jens Axboe <axboe@...nel.dk>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks!

-- 
tejun