linux-kernel - Re: [PATCH v7 2/4] power: reset: add reboot mode driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <570CDC17.1090901@rock-chips.com>
Date:	Tue, 12 Apr 2016 19:29:27 +0800
From:	Andy Yan <andy.yan@...k-chips.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>, robh+dt@...nel.org,
	sre@...nel.org, heiko@...ech.de, john.stultz@...aro.org,
	arnd@...db.de
Cc:	mark.rutland@....com, catalin.marinas@....com, will.deacon@....com,
	alexandre.belloni@...e-electrons.com, f.fainelli@...il.com,
	linux@....linux.org.uk, dbaryshkov@...il.com,
	linux-pm@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	wxt@...k-chips.com, devicetree@...r.kernel.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, lorenzo.pieralisi@....com,
	matthias.bgg@...il.com, linux-arm-kernel@...ts.infradead.org,
	moritz.fischer@...us.com, mbrugger@...e.com,
	linux-kernel@...r.kernel.org, galak@...eaurora.org, olof@...om.net,
	jun.nie@...aro.org, dwmw2@...radead.org
Subject: Re: [PATCH v7 2/4] power: reset: add reboot mode driver

Hi Krzysztof:
     Thanks for you kindly suggestion. I will follow it in next version.

On 2016年04月12日 19:18, Krzysztof Kozlowski wrote:
> On 04/12/2016 11:27 AM, Andy Yan wrote:
>>>>>> +
>>>>>> +static const struct of_device_id syscon_reboot_mode_of_match[] = {
>>>>>> +    { .compatible = "syscon-reboot-mode" },
>>>>>> +    {}
>>>>>> +};
>>>>>> +
>>>>>> +static struct platform_driver syscon_reboot_mode_driver = {
>>>>>> +    .probe = syscon_reboot_mode_probe,
>>>>> Cleanup needed. What will happen after device unbind? Memory will be
>>>>> released (devm-*()) but reboot notifier won't thus leading to OOPS on
>>>>> reboot.
>>>>       From the kernel_restart_prepare function, the reboot notifier will
>>>> be called before device_shutdown. Is there any other case the device
>>>> unbind before reboot notifier
>>>> called?
>>> This is a regular module platform driver so unbind can happen any time
>>> initiated by user, either by unbind command or by module removal. User
>>> can then re-bind device or not - probably does not matter. Anyway after
>>> such first unbind, the restart will kaboom instead of do a restart.
>>      I just need to do clean up in remove?
> Yes, you need to clean up everything in remove() callback (in a reversed
> order).
>
> Best regards,
> Krzysztof
>
>
>