linux-kernel - Re: [PATCH 4.5 026/238] PCI: Disable IO/MEM decoding for devices with non-compliant BARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160412143144.GA10285@kroah.com>
Date:	Tue, 12 Apr 2016 07:31:44 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 4.5 026/238] PCI: Disable IO/MEM decoding for devices
 with non-compliant BARs

On Tue, Apr 12, 2016 at 12:45:13AM +0100, Ben Hutchings wrote:
> On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote:
> > 4.5-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > commit b84106b4e2290c081cdab521fa832596cdfea246 upstream.
> > 
> > The PCI config header (first 64 bytes of each device's config space) is
> > defined by the PCI spec so generic software can identify the device and
> > manage its usage of I/O, memory, and IRQ resources.
> > 
> > Some non-spec-compliant devices put registers other than BARs where the
> > BARs should be.  When the PCI core sizes these "BARs", the reads and writes
> > it does may have unwanted side effects, and the "BAR" may appear to
> > describe non-sensical address space.
> > 
> > Add a flag bit to mark non-compliant devices so we don't touch their BARs.
> > Turn off IO/MEM decoding to prevent the devices from consuming address
> > space, since we can't read the BARs to find out what that address space
> > would be.
> [...]
> 
> No objection, but patch 005/238 seems to depend on this so please
> reorder them so bisection will work.

Now reordered, thanks.

greg k-h