linux-kernel - Re: [PATCH v2] Bluetooth: Deinline large functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1460477690.2507.5.camel@perches.com>
Date:	Tue, 12 Apr 2016 09:14:50 -0700
From:	Joe Perches <joe@...ches.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>,
	Johan Hedberg <johan.hedberg@...el.com>
Cc:	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Deinline large functions

On Tue, 2016-04-12 at 18:08 +0200, Denys Vlasenko wrote:
> On 04/12/2016 05:50 AM, Joe Perches wrote:
> > 
> > On Mon, 2016-04-11 at 20:34 +0200, Denys Vlasenko wrote:
> > > 
> > > Fastest existing Bluetooth standard's top speed is 2.4 MB/s.
> > > It is way off from being CPU limited, no need to squeeze
> > > last few cycles by excessive inlining.
> > > 
> > > Size reduction is about 40k:
> > > 
> > >     text     data      bss       dec     hex filename
> > > 95943139 20860256 35991552 152794947 91b7743 vmlinux_before
> > > 95903714 20860256 35991552 152755522 91add42 vmlinux
> > defconfig?
> In defconfig, CONFIG_BT is not set, so there will be no change

Which is why I set it in the defconfig size I sent.

Also, you haven't responded at all to any performance decrease
by uninline for low power/low frequency SOC embedded uses.