linux-kernel - RE: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198D06D448A18D4E93F08FB849C4E39D7D224C43@BBYEXM01.pmc-sierra.internal>
Date:	Tue, 12 Apr 2016 18:01:46 +0000
From:	Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...s.com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Shane Seymour <shane.seymour@....com>,
	Johannes Thumshirn <jthushirn@...e.de>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH
 recovery

Hello Ben,

> -----Original Message-----
> From: Ben Hutchings [mailto:ben@...adent.org.uk]
> Sent: Monday, April 11, 2016 5:29 PM
> To: Raghava Aditya Renukunta
> Cc: stable@...r.kernel.org; Shane Seymour; Johannes Thumshirn; Martin K.
> Petersen; Greg Kroah-Hartman; LKML
> Subject: Re: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH
> recovery
> 
> On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote:
> > 4.5-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Raghava Aditya Renukunta <raghavaaditya.renukunta@...s.com>
> >
> > commit ecc479e00db8eb110b200afe1effcb3df20ca7ae upstream.
> >
> > During EEH recovery number of online CPU's might change thereby
> changing
> > the number of MSIx vectors. Since each fib is allocated to a vector,
> > changes in the number of vectors causes fib to be sent thru invalid
> > vectors.In addition the correct number of MSIx vectors is not updated in
> > the INIT struct sent to the controller, when it is reinitialized.
> >
> > Fixed by reassigning vectors to fibs based on the updated number of MSIx
> > vectors and updating the INIT structure before sending to controller.
> 
> Really?
> 
> [...]
> > --- a/drivers/scsi/aacraid/linit.c
> > +++ b/drivers/scsi/aacraid/linit.c
> > @@ -1404,8 +1404,18 @@ static int aac_acquire_resources(struct
> >
> >  	aac_adapter_enable_int(dev);
> >
> > -	if (!dev->sync_mode)
> > +	/*max msix may change  after EEH
> > +	 * Re-assign vectors to fibs
> > +	 */
> > +	aac_fib_vector_assign(dev);
> > +
> > +	if (!dev->sync_mode) {
> > +		/* After EEH recovery or suspend resume, max_msix count
> > +		 * may change, therfore updating in init as well.
> > +		 */
> >  		aac_adapter_start(dev);
> > +		dev->init->Sa_MSIXVectors = cpu_to_le32(dev->max_msix);
> 
> Aren't these two lines in the wrong order?
> 
> Ben.

You are right those are two lines are in the wrong order,
I will submit another patch to correct that issue.

Raghava 
> 
> > +	}
> >  	return 0;
> >
> >  error_iounmap:
> --
> Ben Hutchings
> This sentence contradicts itself - no actually it doesn't.