linux-kernel - Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLEui=E22t5=tSNG2nOA7LWO4UNuVknhteTxEZzY+iwyg@mail.gmail.com>
Date:	Tue, 12 Apr 2016 12:46:36 -0700
From:	Kees Cook <keescook@...omium.org>
To:	David Brown <david.brown@...aro.org>, Jeff Law <law@...hat.com>
Cc:	Emese Revfy <re.emese@...il.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Michal Marek <mmarek@...e.com>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	PaX Team <pageexec@...email.hu>,
	Brad Spengler <spender@...ecurity.net>,
	"kernel-hardening@...ts.openwall.com" 
	<kernel-hardening@...ts.openwall.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 0/6] Introduce GCC plugin infrastructure

On Tue, Apr 12, 2016 at 11:41 AM, David Brown <david.brown@...aro.org> wrote:
> On Tue, Apr 12, 2016 at 11:27:52AM -0700, Kees Cook wrote:
>
>> Awesome! Thanks for testing this. I still need to finish getting my
>> arm64 environment built...
>
>
> I've been using:
>  http://releases.linaro.org/components/toolchain/binaries/
>
> for most stuff.
>
>> Do you happen to know if there's already a gcc bug open for the make
>> install problem?
>
>
> Linaro toolchain bug:
>  https://bugs.linaro.org/show_bug.cgi?id=2123
>
> Patch to fix it
>  https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00522.html
>
> It is supposed to be included in the linaro 5.3-2016.03 snapshot.
> I've pinged Christophe to see if I can get any insight into when that
> will be available.

Looks like it's in the upstream tree:

https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=bfe972081c3c75019fa5a6e883dcbeb5e03eea18

I'm not sure how GCC does bug fix releases. Is this going to be in 5.4
or 5.3.1? (Is there such a thing as 5.3.1 planned?) I've CCed Jeff in
case he's got a moment to peek at this.

> It is kind of nice to see that when it fails, it prints a helpful
> message, though:
>
>  scripts/Makefile.gcc-plugins:22: *** error, your gcc installation does not
> support plugins, perhaps the necessary headers are missing?.  Stop.
>
> I think it is OK to include this, even with the patches still bubbling
> through gcc releases.  It prints a helpful message when it doesn't
> work, and is only going to be selected if specifically requested.

Yeah, absolutely. It works on the other architectures, and will soon
work on arm64 too.

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security