linux-kernel - [PATCH 1/6] arm: pmu: Fix non-devicetree probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1460492471-15527-2-git-send-email-jeremy.linton@arm.com>
Date:	Tue, 12 Apr 2016 15:21:06 -0500
From:	Jeremy Linton <jeremy.linton@....com>
To:	linux-kernel@...r.kernel.org
Cc:	will.deacon@....com, mark.rutland@....com, peterz@...radead.org,
	mingo@...hat.com, catalin.marinas@....com, msalter@...hat.com,
	timur@...eaurora.org, nleeder@...eaurora.org,
	agustinv@...eaurora.org, sfr@...b.auug.org.au,
	jan.glauber@...il.com, Jeremy Linton <jeremy.linton@....com>
Subject: [PATCH 1/6] arm: pmu: Fix non-devicetree probing

From: Mark Salter <msalter@...hat.com>

There is a problem in the non-devicetree PMU probing where some
probe functions may get the number of supported events through
smp_call_function_any() using the arm_pmu supported_cpus mask.
But at the time the probe function is called, the supported_cpus
mask is empty so the call fails. This patch makes sure the mask
is set before calling the init function rather than after.

Signed-off-by: Mark Salter <msalter@...hat.com>
Signed-off-by: Jeremy Linton <jeremy.linton@....com>
---
 drivers/perf/arm_pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 32346b5..49fa845 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -997,8 +997,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
 		if (!ret)
 			ret = init_fn(pmu);
 	} else {
-		ret = probe_current_pmu(pmu, probe_table);
 		cpumask_setall(&pmu->supported_cpus);
+		ret = probe_current_pmu(pmu, probe_table);
 	}
 
 	if (ret) {
-- 
2.4.3