linux-kernel - Re: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1460526501.32184.4.camel@mtksdaap41>
Date:	Wed, 13 Apr 2016 13:48:21 +0800
From:	Henry Chen <henryc.chen@...iatek.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Matthias Brugger <matthias.bgg@...il.com>,
	John Crispin <blogic@...nwrt.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Flora Fu <flora.fu@...iatek.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from
 platform_get_irq.

On Mon, 2016-04-11 at 09:50 +0100, Lee Jones wrote:
> On Fri, 08 Apr 2016, Henry Chen wrote:
> 
> > If get the -EPROBE_DEFER from platform_get_irq, it should return back directly.
> > 
> > Signed-off-by: Henry Chen <henryc.chen@...iatek.com>
> > ---
> >  drivers/mfd/mt6397-core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > index 15050cb..b9b1e28 100644
> > --- a/drivers/mfd/mt6397-core.c
> > +++ b/drivers/mfd/mt6397-core.c
> > @@ -271,6 +271,8 @@ static int mt6397_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	pmic->irq = platform_get_irq(pdev, 0);
> > +	if (pmic->irq == -EPROBE_DEFER)
> > +		return -EPROBE_DEFER;
> 
> if (ret < 0)
>    return ret;
> 
> ... is more common, as it covers more bases, etc.

Okay, the interrupt should be a required properties, if get failed just
return back.

I will also change the binding doc.

Thanks.

> 
> >  	switch (id & 0xff) {
> >  	case MT6323_CID_CODE:
>