linux-kernel - Re: [PATCH V2] mtd: nand: pasemi: switch to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160413094440.1b883491@bbrezillon>
Date:	Wed, 13 Apr 2016 09:44:40 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	Richard Weinberger <richard@....at>,
	"open list:MEMORY TECHNOLOGY..." <linux-mtd@...ts.infradead.org>,
	Egor Martovetsky <egor@...emi.com>,
	Olof Johansson <olof@...om.net>, Joe Perches <joe@...ches.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" 
	<linuxppc-dev@...ts.ozlabs.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions

Hi,

On Sat, 9 Apr 2016 12:50:35 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Apr 8, 2016 at 2:13 PM, Rafał Miłecki <zajec5@...il.com> wrote:
> > 1) Use pr_fmt to keep messages consistent
> > 2) Don't warn if kzalloc fails as it dumps stack on its own
> > 3) Use %pR format for displaying whole resource to avoid:
> > warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘resource_size_t’
> >
> > Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> > ---
> >  drivers/mtd/nand/pasemi_nand.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
> > index 63fcb8c..e8372b4 100644
> > --- a/drivers/mtd/nand/pasemi_nand.c
> > +++ b/drivers/mtd/nand/pasemi_nand.c
> > @@ -22,6 +22,8 @@
> >
> >  #undef DEBUG
> >
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> >  #include <linux/slab.h>
> >  #include <linux/module.h>
> >  #include <linux/mtd/mtd.h>
> > @@ -112,8 +114,6 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
> >         /* Allocate memory for MTD device structure and private data */
> >         chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
> >         if (!chip) {
> > -               printk(KERN_WARNING
> > -                      "Unable to allocate PASEMI NAND MTD device structure\n");
> >                 err = -ENOMEM;
> >                 goto out;
> >         }
> > @@ -163,13 +163,12 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
> >         }
> >
> >         if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
> > -               printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n");
> > +               pr_err("Unable to register MTD device\n");
> 
> And why not to use dev_err(&ofdev->dev, …); ?

Yep, I think it's better to use dev_err().

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com