linux-kernel - Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570DFB71.4070106@free.fr>
Date:	Wed, 13 Apr 2016 10:55:29 +0300
From:	Martin Peres <martin.peres@...e.fr>
To:	kbuild test robot <fengguang.wu@...el.com>,
	Karol Herbst <nouveau@...olherbst.de>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Ben Skeggs <bskeggs@...hat.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings

On 13/04/16 10:07, kbuild test robot wrote:
> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
>   NULL check before some freeing functions is not needed.
>
>   Based on checkpatch warning
>   "kfree(NULL) is safe this check is probably not required"
>   and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> CC: Karol Herbst <nouveau@...olherbst.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Martin Peres <martin.peres@...e.fr>