linux-kernel - Re: [PATCH v5 07/14] tools/lguest: force disable tboot and apm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160413084446.GA21471@gmail.com>
Date:	Wed, 13 Apr 2016 10:44:46 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:	bp@...en8.de, hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	rusty@...tcorp.com.au, x86@...nel.org,
	linux-kernel@...r.kernel.org, luto@...capital.net,
	boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
	konrad.wilk@...cle.com, xen-devel@...ts.xensource.com,
	lguest@...ts.ozlabs.org, andriy.shevchenko@...ux.intel.com,
	jlee@...e.com, glin@...e.com, matt@...eblueprint.co.uk,
	andrew.cooper3@...rix.com, rjw@...ysocki.net, lenb@...nel.org,
	robert.moore@...el.com, lv.zheng@...el.com, toshi.kani@...com,
	linux-acpi@...r.kernel.org, kozerkov@...allels.com,
	josh@...htriplett.org, joro@...tes.org, tiwai@...e.de
Subject: Re: [PATCH v5 07/14] tools/lguest: force disable tboot and apm


* Luis R. Rodriguez <mcgrof@...nel.org> wrote:

> The paravirt_enabled() check is going away, the area tossed to
> the kernel on lguest is not zerored out, so ensure lguest force
> disables tboot and apm just in case the kernel file being read might
> have this set for whatever reason.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
> ---
>  tools/lguest/lguest.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Yeah, so the v4 patch was acked by Rusty:

  Acked-by: Rusty Russell <rusty@...tcorp.com.au>

... but you didn't add his ack to the v5 patch :-(

Please don't do this! Also please double check all past replies to make sure no 
acks got lost. I noticed this one, but there might be more.

Thanks,

	Ingo