linux-kernel - [PATCH] atmel-isc: fix compare_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1604131047460.2969@hadrien>
Date:	Wed, 13 Apr 2016 10:49:21 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Songjun Wu <songjun.wu@...el.com>
cc:	linux-arm-kernel@...ts.infradead.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>,
	Fabien Dessenne <fabien.dessenne@...com>,
	Peter Griffin <peter.griffin@...aro.org>,
	Benoit Parrot <bparrot@...com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Gerd Hoffmann <kraxel@...hat.com>,
	Richard Röjfors <richard@...finpack.se>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	kbuild@...org, g.liakhovetski@....de, nicolas.ferre@...el.com
Subject: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings

Move constants to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Songjun Wu <songjun.wu@...el.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

Up to you.  Seems a tiny bit more readable to me not to have ISC_DCTRL and
ISC_DCTRL_IE_IS right together.

 atmel-isc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/media/platform/atmel/atmel-isc.c
+++ b/drivers/media/platform/atmel/atmel-isc.c
@@ -639,7 +639,7 @@ static inline void isc_start_dma(struct

 	addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0);

-	regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview);
+	regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS);
 	regmap_write(regmap, ISC_DAD0, addr);
 	regmap_update_bits(regmap, ISC_CTRLEN,
 			   ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);