lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Apr 2016 13:36:27 +0300 From: "Kirill A. Shutemov" <kirill@...temov.name> To: Jason Baron <jbaron@...mai.com> Cc: akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com, rientjes@...gle.com, aarcange@...hat.com, mgorman@...hsingularity.net, mhocko@...e.com, hannes@...xchg.org, vbabka@...e.cz, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] mm: update min_free_kbytes from khugepaged after core initialization On Tue, Apr 12, 2016 at 03:54:37PM -0400, Jason Baron wrote: > Khugepaged attempts to raise min_free_kbytes if its set too low. However, > on boot khugepaged sets min_free_kbytes first from subsys_initcall(), and > then the mm 'core' over-rides min_free_kbytes after from > init_per_zone_wmark_min(), via a module_init() call. > > Khugepaged used to use a late_initcall() to set min_free_kbytes (such that > it occurred after the core initialization), however this was removed when > the initialization of min_free_kbytes was integrated into the starting of > the khugepaged thread. > > The fix here is simply to invoke the core initialization using a > core_initcall() instead of module_init(), such that the previous > initialization ordering is restored. I didn't restore the late_initcall() > since start_stop_khugepaged() already sets min_free_kbytes via > set_recommended_min_free_kbytes(). > > This was noticed when we had a number of page allocation failures when > moving a workload to a kernel with this new initialization ordering. On an > 8GB system this restores min_free_kbytes back to 67584 from 11365 when > CONFIG_TRANSPARENT_HUGEPAGE=y is set and either > CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS=y or > CONFIG_TRANSPARENT_HUGEPAGE_MADVISE=y. > > Fixes: 79553da293d3 ("thp: cleanup khugepaged startup") > Signed-off-by: Jason Baron <jbaron@...mai.com> Looks good to me: Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> -- Kirill A. Shutemov
Powered by blists - more mailing lists