linux-kernel - Re: [PATCH 1/2] vfs: Define new syscall getumask.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2016 15:40:34 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Florian Weimer <fw@...eb.enyo.de>,
	"Richard W.M. Jones" <rjones@...hat.com>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, akpm@...ux-foundation.org, luto@...nel.org,
	viro@...iv.linux.org.uk, mathieu.desnoyers@...icios.com,
	zab@...hat.com, emunson@...mai.com, paulmck@...ux.vnet.ibm.com,
	aarcange@...hat.com, josh@...htriplett.org, xemul@...allels.com,
	sfr@...b.auug.org.au, milosz@...in.com, rostedt@...dmis.org,
	arnd@...db.de, ebiederm@...ssion.com, iulia.manda21@...il.com,
	dave.hansen@...ux.intel.com, mguzik@...hat.com,
	adobriyan@...il.com, dave@...olabs.net, linux-api@...r.kernel.org
Subject: Re: [PATCH 1/2] vfs: Define new syscall getumask.

On Wed, Apr 13, 2016 at 02:21:35PM +0200, Florian Weimer wrote:
> * Richard W. M. Jones:
> 
> > +SYSCALL_DEFINE0(getumask)
> > +{
> > +	return current->fs->umask;
> > +}
> 
> The convention seems to be to call current_umask(), instead of
> inlining its contents.

Yes, please use existing.