linux-kernel - Re: [PATCH] kcov: Don't trace the code coverage code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2016 18:27:13 +0200
From:	Dmitry Vyukov <dvyukov@...gle.com>
To:	James Morse <james.morse@....com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Potapenko <glider@...gle.com>
Subject: Re: [PATCH] kcov: Don't trace the code coverage code

On Wed, Apr 13, 2016 at 6:22 PM, James Morse <james.morse@....com> wrote:
> Kcov causes the compiler to add a call to __sanitizer_cov_trace_pc() in
> every basic block. Ftrace patches in a call to _mcount() to each function
> it has annotated.
>
> Letting these mechanisms annotate each other is a bad thing. Break the
> loop by adding 'notrace' to __sanitizer_cov_trace_pc() so that ftrace
> won't try to patch this code.
>
> Signed-off-by: James Morse <james.morse@....com>
> ---
> This patch lets arm64 with KCOV and STACK_TRACER boot.
>
>  kernel/kcov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 3efbee0834a8..78bed7125515 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -43,7 +43,7 @@ struct kcov {
>   * Entry point from instrumented code.
>   * This is called once per basic-block/edge.
>   */
> -void __sanitizer_cov_trace_pc(void)
> +void notrace __sanitizer_cov_trace_pc(void)
>  {
>         struct task_struct *t;
>         enum kcov_mode mode;
> --
> 2.8.0.rc3

Thanks!

Acked-by: Dmitry Vyukov <dvyukov@...gle.com>