linux-kernel - Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <570DCD86.40208@samsung.com>
Date:	Wed, 13 Apr 2016 10:09:34 +0530
From:	Alim Akhtar <alim.akhtar@...sung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Cc:	catalin.marinas@....com, will.deacon@....com,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	devicetree@...r.kernel.org, thomas.ab@...sung.com
Subject: Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7

Hi Krzysztof,

On 04/12/2016 07:35 PM, Krzysztof Kozlowski wrote:
> On 04/12/2016 02:49 PM, Alim Akhtar wrote:
>> This patch adds device tree nodes for pdma0 and pdma1 controllers
>> found on exynos7 SoCs.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
>> ---
>>   arch/arm64/boot/dts/exynos/exynos7.dtsi |   29 +++++++++++++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>
>
> I would prefer avoid adding all new stuff at the end because it is
> conflict-prone. Alphabetical order or by address... but none of these
> are used currently. How about putting it after 'gic' node?
>
hmm....ok will send v2 with suggested changes.
Looks like other platforms also put it below 'gic'.

> Anyway the code looks fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>
> Best regards,
> Krzysztof
>
>