linux-kernel - Re: [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOesGMj1zAgr+urvJHUu9=-P5RR5d9Ko6bUpXKTUcwkXMeYydg@mail.gmail.com>
Date:	Wed, 13 Apr 2016 15:04:13 -0700
From:	Olof Johansson <olof@...om.net>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...inux.com" <kernel@...inux.com>,
	Maxime Coquelin <maxime.coquelin@...com>,
	Ohad Ben-Cohen <ohad@...ery.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Nathan Lynch <Nathan_Lynch@...tor.com>,
	Florian Fainelli <f.fainelli@...il.com>, ludovic.barre@...com,
	Suman Anna <s-anna@...com>
Subject: Re: [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc

Hi,

On Tue, Jan 12, 2016 at 4:46 AM, Lee Jones <lee.jones@...aro.org> wrote:
> Signed-off-by: Ludovic Barre <ludovic.barre@...com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 40 +++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 1e4e01925..15c20b6 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -650,5 +650,45 @@
>                         mbox-name       = "st231_audio_video";
>                         status          = "okay";
>                 };
> +
> +               st231_gp0: st231-gp0@...00000 {

These node names seem odd. Should probably be more generic
"remoteproc@...00000".

> +                       compatible      = "st,st231-rproc";
> +                       reg             = <0x40000000 0x01000000>;

This isn't what the binding says, it uses a memory region instead.



-Olof