linux-kernel - Re: [Xen-devel] [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160413224948.GI1990@wotan.suse.de>
Date:	Thu, 14 Apr 2016 00:49:48 +0200
From:	"Luis R. Rodriguez" <mcgrof@...nel.org>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:	Juergen Gross <jgross@...e.com>, bp@...en8.de, hpa@...or.com,
	tglx@...utronix.de, mingo@...hat.com, rusty@...tcorp.com.au,
	kozerkov@...allels.com, matt@...eblueprint.co.uk,
	lv.zheng@...el.com, xen-devel@...ts.xensource.com, joro@...tes.org,
	x86@...nel.org, robert.moore@...el.com, linux-acpi@...r.kernel.org,
	glin@...e.com, lenb@...nel.org, josh@...htriplett.org,
	jlee@...e.com, lguest@...ts.ozlabs.org, boris.ostrovsky@...cle.com,
	andriy.shevchenko@...ux.intel.com, toshi.kani@...com,
	andrew.cooper3@...rix.com, rjw@...ysocki.net,
	linux-kernel@...r.kernel.org, luto@...capital.net,
	david.vrabel@...rix.com, tiwai@...e.de
Subject: Re: [Xen-devel] [PATCH v5 04/14] x86/rtc: replace paravirt rtc check
 with platform legacy quirk

On Tue, Apr 12, 2016 at 10:50:56PM +0200, Luis R. Rodriguez wrote:
> On Mon, Apr 11, 2016 at 08:50:19AM +0200, Juergen Gross wrote:
> > On 09/04/16 01:40, Luis R. Rodriguez wrote:
> > > TOTAL   TEXT   init.text    x86_early_init_platform_quirks()
> > > +70     +62    +62          +43
> > > 
> > > Only 8 bytes overhead total, as the main increase in size is
> > > all removed via __init.
> > 
> > I think this could be even less 

> > > +static void xen_dom0_set_legacy_features(void)
> > 
> > Can't you make this __init ?
> 
> Indeed, will change.

0-day tests indicates no size gains, that might be a build cache
issue not sure. Either way, will fold the __init change into
a v6.

  Luis