linux-kernel - Re: [PATCH v4 0/8] block: prepare for multipage bvecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVN5ifhRiyW8ovugYrwVE_p8DOsLXW_fZ95WV0+54w0mGw@mail.gmail.com>
Date:	Fri, 15 Apr 2016 06:22:33 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Jens Axboe <axboe@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-block@...r.kernel.org, Christoph Hellwig <hch@...radead.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	"open list:DRBD DRIVER" <drbd-dev@...ts.linbit.com>,
	Jan Kara <jack@...e.cz>, Keith Busch <keith.busch@...el.com>,
	Kent Overstreet <kent.overstreet@...il.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Mike Snitzer <snitzer@...hat.com>, Shaohua Li <shli@...com>,
	Tejun Heo <tj@...nel.org>,
	"open list:XFS FILESYSTEM" <xfs@....sgi.com>
Subject: Re: [PATCH v4 0/8] block: prepare for multipage bvecs

On Thu, Apr 14, 2016 at 10:11 PM, Jens Axboe <axboe@...nel.dk> wrote:
> On 04/14/2016 05:46 AM, Ming Lei wrote:
>>
>> Hi,
>>
>> Interests[1] have been shown in multipage bvecs, so this patchset
>> try to prepare for the support and do two things:
>>
>> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
>> then we can drop the non-standard way for iterating bvec, which
>> can be thought as a good cleanup for lib/iov_iter.c
>>
>> 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only
>> one user for each. Once multipage bvecs is introduced, one bio
>> may hold lots of sectors, and we should always use sort of BIO_MAX_VECS
>> which should be introduced in future and is similiar with current
>> BIO_MAX_PAGES.
>>
>> xfstests(-a auto) have been run over ext4/xfs and no regression found
>> by this patchset.
>
>
> We've had too many disasters in the block layer the last few series, I'm
> making the 4.7 round a nice and small one. I don't mind taking prep patches
> for the multipage bvecs, if they are simple and clean, but that's about the
> extent of it.
>
> Just a heads up.

Jens, thanks for your response, and understood your concerns.

Please hold on this patchset, and I will check it further and make it
better.

Thanks,