linux-kernel - Re: [PATCH 18/19] crypto: get rid of superfluous __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160414070216.GA2850@dhcp22.suse.cz>
Date:	Thu, 14 Apr 2016 09:02:17 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 18/19] crypto: get rid of superfluous __GFP_REPEAT

On Thu 14-04-16 14:27:31, Herbert Xu wrote:
> On Mon, Apr 11, 2016 at 01:08:11PM +0200, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@...e.com>
> > 
> > __GFP_REPEAT has a rather weak semantic but since it has been introduced
> > around 2.6.12 it has been ignored for low order allocations.
> > 
> > lzo_init uses __GFP_REPEAT to allocate LZO1X_MEM_COMPRESS 16K. This is
> > order 3 allocation request and __GFP_REPEAT is ignored for this size
> > as well as all <= PAGE_ALLOC_COSTLY requests.
> > 
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Signed-off-by: Michal Hocko <mhocko@...e.com>
> 
> Could you please send this patch to the linux-crypto list? Thanks.

Will do. Do you prefer it now as a stand along patch or when I repost
the full series. This one doesn't depend on any previous so I can do
both ways.

Thanks!
-- 
Michal Hocko
SUSE Labs