linux-kernel - [patch] target/transport: Silence unitialized variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2016 12:32:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Bart Van Assche <bart.vanassche@...disk.com>
Cc:	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Jon Mason <jonmason@...adcom.com>,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [patch] target/transport: Silence unitialized variable warnings

The core_scsi3_ua_for_check_condition() can return without initializing
these variables.  I have initialized them to zero so that it triggers a
WARN_ON_ONCE() in that situation.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index ab2bf12..851e634 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -2884,7 +2884,8 @@ static int translate_sense_reason(struct se_cmd *cmd, sense_reason_t reason)
 	const struct sense_info *si;
 	u8 *buffer = cmd->sense_buffer;
 	int r = (__force int)reason;
-	u8 asc, ascq;
+	u8 asc = 0;
+	u8 ascq = 0;
 	bool desc_format = target_sense_desc_format(cmd->se_dev);
 
 	if (r < ARRAY_SIZE(sense_info_table) && sense_info_table[r].key)