linux-kernel - Re: [patch] mfd: wm8400-core: signedness bug in wm8400_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160414100135.GS31814@localhost.localdomain>
Date:	Thu, 14 Apr 2016 11:01:35 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Lee Jones <lee.jones@...aro.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	<patches@...nsource.wolfsonmicro.com>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] mfd: wm8400-core: signedness bug in wm8400_reg_read()

On Thu, Apr 14, 2016 at 12:40:55PM +0300, Dan Carpenter wrote:
> This is harmless because the function is not called, but we're trying to
> return negative error codes so the function needs to return an int
> instead of a u16.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

That patch looks fine, but the function appears to be completely
unused, perhaps just a patch to remove it would be better?

Thanks,
Charles