linux-kernel - Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570FA46B.2080706@collabora.com>
Date:	Thu, 14 Apr 2016 16:08:43 +0200
From:	Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:	Emil Velikov <emil.l.velikov@...il.com>
CC:	Thierry Reding <treding@...dia.com>,
	devicetree <devicetree@...r.kernel.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	David Airlie <airlied@...ux.ie>,
	Rob Herring <robh+dt@...nel.org>,
	Daniel Kurtz <djkurtz@...omium.org>, drinkcat@...omium.org,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

Hi Emil,

On 14/04/16 16:06, Emil Velikov wrote:
> Hi Enric,
>
> On 14 April 2016 at 14:42, Enric Balletbo i Serra
> <enric.balletbo@...labora.com> wrote:
>> The patch was implemented first without OR'ing error codes. The reason why I
>> changed this is because I received the comments that checking the error on
>> every regmap_* didn't help the readability of the driver and is likely to
>> not fail if the first call doesn't fail.
>>
>> For example, originally the code was like this:
>>    http://pastebin.com/rPgyji8k
>> but I changed to this
>>    http://pastebin.com/rPgyji8k
>>
> Both links are the same ;-) But I believe we all get what you meant.
>

Ooops, sorry. This is the other link

http://pastebin.com/e2KpGxHy

> Just a side note: many other drivers in DRM subsystem, inconsistently
> check the return value of the regmap API. Note sure how likely is any
> of it [regmap_foo] to fail and/or how determined people are to handle
> every possible error case.
>
> -Emil
>

Enric