linux-kernel - Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160414151815.GG18024@sirena.org.uk>
Date:	Thu, 14 Apr 2016 16:18:15 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	linux-kernel@...r.kernel.org, rjendra@....qualcomm.com
Subject: Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage

On Thu, Apr 14, 2016 at 01:35:03PM +0100, Srinivas Kandagatla wrote:

> I totally agree that there is an abstraction failure here in both sides. It
> should be fixed. moving to using bulk apis would solve the nvmem problem for
> now. But for long term, using regmap should be totally removed from nvmem
> and directly use the reg read/write callbacks from nvmem providers, This
> would be much robust solution. This was indeed Maxime's first proposal. I
> will try to fix it up and see how it looks without regmap.

OK, so just replacing all the _raw_ calls with _bulk_ for now?  If
you're doing that watch out for the fact that the reads come back native
endian which might upset things.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)