linux-kernel - Re: [PATCH V1] regulator: pv88080: new regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160414154059.GI18024@sirena.org.uk>
Date:	Thu, 14 Apr 2016 16:40:59 +0100
From:	Mark Brown <broonie@...nel.org>
To:	James Bans <James.Ban.opensource@...semi.com>
Cc:	LINUXKERNEL <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH V1] regulator: pv88080: new regulator driver

On Thu, Apr 14, 2016 at 04:32:04PM +0900, James Bans wrote:

A couple of minor points but otherwise this looks good:

> +static const int pv88080_buck2_limits[] = {
> +	1496000, 2393000, 3291000, 4189000
> +};
> +
> +static const int pv88080_buck3_limits[] = {
> +	1496000, 2393000, 3291000, 4189000
> +};

These two appear identical so should just be one array.

> +	switch (data & PV88080_BUCK1_MODE_MASK) {
> +	case PV88080_BUCK_MODE_SYNC:
> +		mode = REGULATOR_MODE_FAST;
> +		break;
> +	case PV88080_BUCK_MODE_AUTO:
> +		mode = REGULATOR_MODE_NORMAL;
> +		break;
> +	case PV88080_BUCK_MODE_SLEEP:
> +		mode = REGULATOR_MODE_STANDBY;
> +		break;
> +	}

I know mode was initialized above but this would be clearer with a
default: case.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)