linux-kernel - Re: [PATCH] regulator: reorder initialization steps in regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160414182137.3257fa82@bbrezillon>
Date:	Thu, 14 Apr 2016 18:21:37 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, Caesar Wang <wxt@...k-chips.com>,
	Heiko Stübner <heiko@...ech.de>,
	Stephen Barber <smbarber@...omium.org>,
	Douglas Anderson <dianders@...omium.org>,
	Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH] regulator: reorder initialization steps in
 regulator_register()

Hi Thierry,

On Wed, 13 Apr 2016 07:41:40 +0100
Mark Brown <broonie@...nel.org> wrote:

> On Tue, Apr 12, 2016 at 12:31:00PM +0200, Boris Brezillon wrote:
> > device_register() is calling ->get_voltage() as part of is sysfs attribute
> > initialization process, and this functions might need to know the regulator
> > constraints to return a valid value.

I realize you were not CCed for this patch, but if we want all the
pwm-atomic support changes (including the pwm-regulator ones) to go
through your tree, you'll have to pull the following branch before
applying "regulator: pwm: retrieve correct voltage".

> 
> I've pushed this as a signed tag:
> 
> The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:
> 
>   Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git tags/regulator-sysfs-init-order
> 
> for you to fetch changes up to 469b640e4f4a28bdd50f0ac1d2b310907afb464c:
> 
>   regulator: reorder initialization steps in regulator_register() (2016-04-13 07:33:44 +0100)
> 
> ----------------------------------------------------------------
> regulator: Pull the sysfs init after constraint setup
> 
> The sysfs attributes can indirectly use information from the constraints
> so can trigger warnings with some systems.
> 
> ----------------------------------------------------------------
> Boris Brezillon (1):
>       regulator: reorder initialization steps in regulator_register()
> 
>  drivers/regulator/core.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)


Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com