linux-kernel - Re: [PATCH] staging/rdma/hfi1: select CRC32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160414175922.GB11641@rhel.sc.intel.com>
Date:	Thu, 14 Apr 2016 13:59:22 -0400
From:	Ira Weiny <ira.weiny@...el.com>
To:	Markus Böhme <markus.boehme@...lbox.org>
Cc:	devel@...verdev.osuosl.org,
	Mike Marciniszyn <infinipath@...el.com>,
	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/rdma/hfi1: select CRC32

On Fri, Apr 01, 2016 at 01:04:05AM +0200, Markus Böhme wrote:
> The function parse_platform_config in firmware.c calls crc32_le.
> Building without CRC32 selected causes a link error:
> 
> drivers/built-in.o: In function `parse_platform_config':
> (.text+0x92ffa): undefined reference to `crc32_le'
> 
> Signed-off-by: Markus Böhme <markus.boehme@...lbox.org>

Doug did you pick this up?

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> ---
>  drivers/staging/rdma/hfi1/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig
> index 3e668d8..a925fb0 100644
> --- a/drivers/staging/rdma/hfi1/Kconfig
> +++ b/drivers/staging/rdma/hfi1/Kconfig
> @@ -2,6 +2,7 @@ config INFINIBAND_HFI1
>  	tristate "Intel OPA Gen1 support"
>  	depends on X86_64 && INFINIBAND_RDMAVT
>  	select MMU_NOTIFIER
> +	select CRC32
>  	default m
>  	---help---
>  	This is a low-level driver for Intel OPA Gen1 adapter.
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html