linux-kernel - Re: [PATCH 05/14] drm/msm: use drm_crtc_send_vblank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2016 16:51:06 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Gustavo Padovan <gustavo@...ovan.org>
Cc:	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Ander Conselvan de Oliveira <conselvan2@...il.com>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
	Hai Li <hali@...eaurora.org>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Archit Taneja <architt@...eaurora.org>,
	Daniel Stone <daniels@...labora.com>,
	jilai wang <jilaiw@...eaurora.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/14] drm/msm: use drm_crtc_send_vblank_event()

On Thu, Apr 14, 2016 at 1:48 PM, Gustavo Padovan <gustavo@...ovan.org> wrote:
> From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
>
> Replace the legacy drm_send_vblank_event() with the new helper function.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>

thanks, shall I take this via msm-next for 4.7, I assume?  Looks like
no dependency on drm-core patches that haven't already landed?

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 2 +-
>  drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
> index e233acf..3a48889 100644
> --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
> +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
> @@ -121,7 +121,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file)
>                 if (!file || (event->base.file_priv == file)) {
>                         mdp4_crtc->event = NULL;
>                         DBG("%s: send event: %p", mdp4_crtc->name, event);
> -                       drm_send_vblank_event(dev, mdp4_crtc->id, event);
> +                       drm_crtc_send_vblank_event(crtc, event);
>                 }
>         }
>         spin_unlock_irqrestore(&dev->event_lock, flags);
> diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
> index 9673b95..ce779d9 100644
> --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
> +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
> @@ -149,7 +149,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file)
>                 if (!file || (event->base.file_priv == file)) {
>                         mdp5_crtc->event = NULL;
>                         DBG("%s: send event: %p", mdp5_crtc->name, event);
> -                       drm_send_vblank_event(dev, mdp5_crtc->id, event);
> +                       drm_crtc_send_vblank_event(crtc, event);
>                 }
>         }
>         spin_unlock_irqrestore(&dev->event_lock, flags);
> --
> 2.5.5
>