linux-kernel - Re: [PATCH 14/16] vfs: Implement mount_super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 16:02:49 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>, security@...ian.org,
	"security@...nel.org" <security@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	"security@...ntu.com >> security" <security@...ntu.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Serge Hallyn <serge.hallyn@...ntu.com>,
	Willy Tarreau <w@....eu>,
	Aurelien Jarno <aurelien@...el32.net>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Jann Horn <jann@...jh.net>, Greg KH <greg@...ah.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jslaby@...e.com>, Florian Weimer <fw@...eb.enyo.de>
Subject: Re: [PATCH 14/16] vfs: Implement mount_super_once

On Fri, Apr 15, 2016 at 8:35 AM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
> The devpts filesystem has a notion of a system or primary instance of
> devpts.  To retain the notion of a primary system instance of devpts
> the code needs a way to allow userspace to mount the internally
> mounted instance of devpts when it is not currently mounted by
> userspace.  The new helper mount_super_once allows that.

This is where I stopped reading this patch series.

No.

We want to get *rid* of the idiotic "primary instance" crap.

The whole and only point of doing the "which pts filesystem am I
associated with" for ptmx is to stop the idiotic "one devpts is
pecial".

I don't want to see 16 random patches.

I want to see *one* patch that makes /dev/ptmx look up the pts
filesystem, and be done with it.

Plonk.

                   Linus