linux-kernel - [PATCH] ti-st: Fix complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1460708547-17498-1-git-send-email-wagi@monom.org>
Date:	Fri, 15 Apr 2016 10:22:27 +0200
From:	Daniel Wagner <wagi@...om.org>
To:	linux-kernel@...r.kernel.org
Cc:	Daniel Wagner <daniel.wagner@...-carit.de>,
	Pavan Savoy <pavan_savoy@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH] ti-st: Fix complete_all() wrong usage

From: Daniel Wagner <daniel.wagner@...-carit.de>

complete_all() should only be called once, doing it twice is a clear bug.

8565adbc8214 ("drivers/misc/ti-st: fix read fw version cmd") added the
additional complete_all() call. Since we call complete_all() when
leaving the function we can drop the complete_all() call inside
true branch of the if statement.

Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
Cc: Pavan Savoy <pavan_savoy@...com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
Hi,

I found this one when looking though all the complete_all() users. It
is only compile tested.

cheers,
daniel

drivers/misc/ti-st/st_kim.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index 71b6455..bf0d770 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -78,7 +78,6 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata)
 		memcpy(kim_gdata->resp_buffer,
 				kim_gdata->rx_skb->data,
 				kim_gdata->rx_skb->len);
-		complete_all(&kim_gdata->kim_rcvd);
 		kim_gdata->rx_state = ST_W4_PACKET_TYPE;
 		kim_gdata->rx_skb = NULL;
 		kim_gdata->rx_count = 0;
-- 
2.5.5