linux-kernel - Re: [RFC PATCH 1/1] powerpc/fsl: Fix build of the dtb embedded kernel images

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPk1OjHEe+qcPYakD0BbikSkK+Dipj-9P2vatSceTcjMWYAPYg@mail.gmail.com>
Date:	Fri, 15 Apr 2016 10:27:17 +0200
From:	Alessio Igor Bogani <alessio.bogani@...ttra.eu>
To:	Scott Wood <oss@...error.net>,
	Kumar Gala <galak@...nel.crashing.org>,
	linuxppc-dev@...ts.ozlabs.org
Cc:	Alessio Igor Bogani <alessio.bogani@...ttra.eu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/1] powerpc/fsl: Fix build of the dtb embedded kernel images

Hi,

On 6 April 2016 at 15:45, Alessio Igor Bogani <alessio.bogani@...ttra.eu> wrote:
> The commit dc37374 move a lot of device tree files into fsl directory
> fixing Makefile for cuImage target only. Unfortunately there are others
> target which require to embebbed device tree into the kernel image
> (i.e. dtbImage.%). So use a more generic approach.
>
> Signed-off-by: Alessio Igor Bogani <alessio.bogani@...ttra.eu>
> ---
>  arch/powerpc/boot/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index 6116510..8fe78a3 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -362,9 +362,6 @@ $(obj)/cuImage.initrd.%: vmlinux $(obj)/%.dtb $(wrapperbits)
>  $(obj)/cuImage.%: vmlinux $(obj)/%.dtb $(wrapperbits)
>         $(call if_changed,wrap,cuboot-$*,,$(obj)/$*.dtb)
>
> -$(obj)/cuImage.%: vmlinux $(obj)/fsl/%.dtb $(wrapperbits)
> -       $(call if_changed,wrap,cuboot-$*,,$(obj)/fsl/$*.dtb)
> -
>  $(obj)/simpleImage.initrd.%: vmlinux $(obj)/%.dtb $(wrapperbits)
>         $(call if_changed,wrap,simpleboot-$*,,$(obj)/$*.dtb,$(obj)/ramdisk.image.gz)
>
> @@ -381,6 +378,9 @@ $(obj)/treeImage.%: vmlinux $(obj)/%.dtb $(wrapperbits)
>  $(obj)/%.dtb: $(src)/dts/%.dts FORCE
>         $(call if_changed_dep,dtc)
>
> +$(obj)/%.dtb: $(src)/dts/fsl/%.dts FORCE
> +       $(call if_changed_dep,dtc)
> +
>  # If there isn't a platform selected then just strip the vmlinux.
>  ifeq (,$(image-y))
>  image-y := vmlinux.strip

Any comments?

Ciao,
Alessio