linux-kernel - Re: [PATCH] namespace: update event counter when umounting a deleted dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160415005038.GU25498@ZenIV.linux.org.uk>
Date:	Fri, 15 Apr 2016 01:50:38 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrey Ulanov <andreyu@...gle.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] namespace: update event counter when umounting a deleted
 dentry

On Thu, Apr 14, 2016 at 04:48:32PM -0700, Andrey Ulanov wrote:
> +++ b/fs/namespace.c
> @@ -1562,6 +1562,7 @@ void __detach_mounts(struct dentry *dentry)
>  		goto out_unlock;
>  
>  	lock_mount_hash();
> +	event++;

That part makes sense.

> -/* 
> +/*
>   * Is the caller allowed to modify his namespace?
>   */
>  static inline bool may_mount(void)
> @@ -1765,6 +1766,7 @@ void drop_collected_mounts(struct vfsmount *mnt)
>  {
>  	namespace_lock();
>  	lock_mount_hash();
> +	event++;

... but what the hell is this one for?