linux-kernel - Re: [PATCH] staging: fsl-mc: bus: Drop warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 12:43:31 +0200
From:	Matthias Brugger <mbrugger@...e.com>
To:	Stuart Yoder <stuart.yoder@....com>,
	"German.Rivera@...escale.com" <German.Rivera@...escale.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:	Scott Wood <scott.wood@....com>, "agraf@...e.de" <agraf@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging: fsl-mc: bus: Drop warning



On 15/04/16 00:57, Stuart Yoder wrote:
>
>
>> -----Original Message-----
>> From: Matthias Brugger [mailto:mbrugger@...e.com]
>> Sent: Thursday, April 14, 2016 4:24 PM
>> To: German.Rivera@...escale.com; gregkh@...uxfoundation.org
>> Cc: Stuart Yoder <stuart.yoder@....com>; Scott Wood <scott.wood@....com>; agraf@...e.de; linux-
>> kernel@...r.kernel.org; devel@...verdev.osuosl.org; mbrugger@...e.com
>> Subject: [PATCH] staging: fsl-mc: bus: Drop warning
>>
>> When updating the irq_chip and msi_domain_ops, the code checkes for
>> already present functions.
>> When more then one ITS controller are present in the system,
>> irq_chip and msi_domain_ops got already set and a warning is invoked.
>
> How can this situation happen?  And what do you mean by
> multiple ITS controllers? ...multiple instances of the GIC ITS
> on an SoC?
>

Yes, there are two arm,gic-v3-its defined in the FDT.

~ # ll /proc/device-tree/interrupt-controller@...0\,00000000/
total 0
-r--r--r-- 1 root root  4 Apr 15 12:31 #address-cells
-r--r--r-- 1 root root 11 Apr 15 12:31 compatible
drwxr-xr-x 2 root root  0 Apr 15 12:31 gic-its@...0,00020000
drwxr-xr-x 2 root root  0 Apr 15 12:31 gic-its@...0,00020000
-r--r--r-- 1 root root  4 Apr 15 12:31 #interrupt-cells
-r--r--r-- 1 root root  0 Apr 15 12:31 interrupt-controller
-r--r--r-- 1 root root 12 Apr 15 12:31 interrupts
-r--r--r-- 1 root root  4 Apr 15 12:31 linux,phandle
-r--r--r-- 1 root root 21 Apr 15 12:31 name
-r--r--r-- 1 root root  4 Apr 15 12:31 phandle
-r--r--r-- 1 root root  0 Apr 15 12:31 ranges
-r--r--r-- 1 root root  4 Apr 15 12:31 #redistributor-regions
-r--r--r-- 1 root root 48 Apr 15 12:31 reg
-r--r--r-- 1 root root  4 Apr 15 12:31 #size-cells

Regards,
Matthias