linux-kernel - Re: [PATCH v2 2/2] arm64: vhe: Verify CPU Exception Levels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160415135513.GJ22906@arm.com>
Date:	Fri, 15 Apr 2016 14:55:13 +0100
From:	Will Deacon <will.deacon@....com>
To:	Suzuki K Poulose <Suzuki.Poulose@....com>
Cc:	Christoffer Dall <christoffer.dall@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, marc.zyngier@....com,
	catalin.marinas@....com, linux-kernel@...r.kernel.org,
	mark.rutland@....com
Subject: Re: [PATCH v2 2/2] arm64: vhe: Verify CPU Exception Levels

On Thu, Apr 14, 2016 at 01:54:50PM +0100, Suzuki K Poulose wrote:
> On 14/04/16 13:19, Christoffer Dall wrote:
> >On Wed, Apr 13, 2016 at 02:41:33PM +0100, Suzuki K Poulose wrote:
> 
> >>diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> >>index b2d5f4e..e97af155 100644
> >>--- a/arch/arm64/kernel/smp.c
> >>+++ b/arch/arm64/kernel/smp.c
> >>@@ -75,6 +75,43 @@ enum ipi_msg_type {
> >>  	IPI_WAKEUP
> >>  };
> >>
> >>+#ifdef CONFIG_ARM64_VHE
> >>+
> >>+/* Whether the boot CPU is running in HYP mode or not*/
> >>+bool boot_cpu_hyp_mode;
> >
> >you can make this static now.
> 
> Ah ! Good catch.
> 
> 
> >
> >Otherwise,
> >
> >Reviewed-by: Christoffer Dall <christoffer.dall@...aro.org>

Thanks. I'll queue both of those with the static change and
Christoffer's ack.

Will