linux-kernel - Re: [PATCH] drm/amdgpu: fix compare_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1604151617370.3050@hadrien>
Date:	Fri, 15 Apr 2016 16:20:58 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Christian König <christian.koenig@....com>
cc:	Julia Lawall <julia.lawall@...6.fr>,
	Dave Airlie <airlied@...hat.com>, kbuild-all@...org,
	Alex Deucher <alexander.deucher@....com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	joe@...ches.com
Subject: Re: [PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings



On Fri, 15 Apr 2016, Christian König wrote:

> Am 15.04.2016 um 09:15 schrieb Julia Lawall:
> > Move constants to the right of binary operators.
> >
> > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
>
> In general the patch looks ok, but do we have a documented preference where to
> place constants in the coding style docs?
>
> While it's not so much of a problem any more with modern compilers, some
> people still prefer to have it on the left side to catch accidental value
> assignments.

I don't know if it is documented.  Joe Perches suggested that on the right
was better in general - maybe he knows if this is written somewhere.

There are 504 occurrences of NULL == in the kernel, and 19524 occurrences
of == NULL.

julia

>
> Regards,
> Christian.
>
> > ---
> >
> > Could be nice to put the thing being tested first.
> >
> >   amdgpu_grph_object_id_helpers.c |    4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_grph_object_id_helpers.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_grph_object_id_helpers.c
> > @@ -169,11 +169,11 @@ struct graphics_object_id amdgpu_object_
> >   	struct graphics_object_id go_id = { 0 };
> >     	type = object_type_from_bios_object_id(bios_object_id);
> > -	if (OBJECT_TYPE_UNKNOWN == type)
> > +	if (type == OBJECT_TYPE_UNKNOWN)
> >   		return go_id;
> >     	enum_id = enum_id_from_bios_object_id(bios_object_id);
> > -	if (ENUM_ID_UNKNOWN == enum_id)
> > +	if (enum_id == ENUM_ID_UNKNOWN)
> >   		return go_id;
> >     	go_id = display_graphics_object_id_init(
>
>