linux-kernel - Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5710F9E0.2050900@fb.com>
Date:	Fri, 15 Apr 2016 08:25:36 -0600
From:	Jens Axboe <axboe@...com>
To:	Ming Lei <ming.lei@...onical.com>, <linux-kernel@...r.kernel.org>
CC:	<linux-block@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Keith Busch <keith.busch@...el.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	"4.5" <stable@...r.kernel.org>
Subject: Re: [PATCH] block: loop: fix filesystem corruption in case of aio/dio

On 04/15/2016 04:51 AM, Ming Lei wrote:
> Starting from commit e36f620428(block: split bios to max possible length),
> block core starts to split bio in the middle of bvec.
>
> Unfortunately loop dio/aio doesn't consider this situation, and
> always treat 'iter.iov_offset' as zero. Then filesystem corruption
> is observed.
>
> This patch figures out the offset of the base bvevc via
> 'bio->bi_iter.bi_bvec_done' and fixes the issue by passing the offset
> to iov iterator.
>
> Fixes: e36f6204288088f (block: split bios to max possible length)
> Cc: Keith Busch <keith.busch@...el.com>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: stable@...r.kernel.org (4.5)
> Signed-off-by: Ming Lei <ming.lei@...onical.com>

Thanks Ming, queued up.

-- 
Jens Axboe