linux-kernel - Re: [PATCH v6 3/4] soc: mediatek: Add MT2701 power dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 22:42:09 +0800
From:	Yingjoe Chen <yingjoe.chen@...iatek.com>
To:	James Liao <jamesjj.liao@...iatek.com>
CC:	Matthias Brugger <matthias.bgg@...il.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Rob Herring <robh@...nel.org>, <srv_heupstream@...iatek.com>,
	<devicetree@...r.kernel.org>, Kevin Hilman <khilman@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-mediatek@...ts.infradead.org>,
	Shunli Wang <shunli.wang@...iatek.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 3/4] soc: mediatek: Add MT2701 power dt-bindings

On Fri, 2016-04-15 at 10:02 +0800, James Liao wrote:
> Hi Yingjoe,
> 
> On Thu, 2016-04-14 at 18:56 +0800, Yingjoe Chen wrote:
> > On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote:
> > > From: Shunli Wang <shunli.wang@...iatek.com>
> > > 
> > > Add power dt-bindings for MT2701.
> > > 
> > > Signed-off-by: Shunli Wang <shunli.wang@...iatek.com>
> > > Signed-off-by: James Liao <jamesjj.liao@...iatek.com>
> > > Acked-by: Rob Herring <robh@...nel.org>
> > > Reviewed-by: Kevin Hilman <khilman@...libre.com>
> > > ---
> > >  .../devicetree/bindings/soc/mediatek/scpsys.txt    | 12 ++++++----
> > >  include/dt-bindings/power/mt2701-power.h           | 27 ++++++++++++++++++++++
> > >  2 files changed, 34 insertions(+), 5 deletions(-)
> > >  create mode 100644 include/dt-bindings/power/mt2701-power.h
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> > > index e8f15e3..ebb3144 100644
> > > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> > > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> > > @@ -9,17 +9,19 @@ domain control.
> > >  
> > >  The driver implements the Generic PM domain bindings described in
> > >  power/power_domain.txt. It provides the power domains defined in
> > > -include/dt-bindings/power/mt8173-power.h.
> > > +include/dt-bindings/power/mt8173-power.h and mt2701-power.h.
> > >  
> > >  Required properties:
> > > -- compatible: Must be "mediatek,mt8173-scpsys"
> > > +- compatible: Should be one of:
> > > +	- "mediatek,mt2701-scpsys"
> > > +	- "mediatek,mt8173-scpsys"
> > >  - #power-domain-cells: Must be 1
> > >  - reg: Address range of the SCPSYS unit
> > >  - infracfg: must contain a phandle to the infracfg controller
> > >  - clock, clock-names: clocks according to the common clock binding.
> > > -                      The clocks needed "mm", "mfg", "venc" and "venc_lt".
> > > -		      These are the clocks which hardware needs to be enabled
> > > -		      before enabling certain power domains.
> > > +                      The clocks needed "mm", "mfg", "venc", "venc_lt" and
> > > +                      "ethif". These are the clocks which hardware needs to be
> > > +                      enabled before enabling certain power domains.
> > 
> > 
> > Clock ethif only exist on mt2701 so it is not required on mt8173.
> 
> You are right. Each SoC needs different clock for each power domain.
> Here list all subsystems of available SoCs.

Binding should list required clocks for each specific platform. How
about this:

- clock, clock-names: clocks according to the common clock binding.
		      These are the clocks which hardware needs to be
                      enabled before enabling certain power domains.
  	Required clocks for mt2701: "mm", "mfg", "ethif"
	Required clocks for mt8173: "mm", "mfg", "venc", "venc_lt"

Joe.C