linux-kernel - Re: [PATCH] pm80xx: Remove bogus address masking in pm8001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1vb3jsijr.fsf@sermon.lab.mkp.net>
Date:	Thu, 14 Apr 2016 22:38:16 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	David Daney <ddaney.cavm@...il.com>
Cc:	Jack Wang <jinpu.wang@...fitbricks.com>, lindar_liu@...sh.com,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>, pmchba@...s.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap()

>>>>> "David" == David Daney <ddaney.cavm@...il.com> writes:

David> It is unclear what the original intent of the masking was, but it
David> is clearly incorrect to truncate a physical address before
David> calling ioremap().  On systems where there are valid physical
David> address bits above bit-31 (arm64 for example) the result is an
David> eventual OOPs when initializing the driver.

David> Remove the bogus code to fix it.

Applied to 4.7/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering