linux-kernel - Re: [PATCHv2 1/2] target: make target db location configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57103029.80007@suse.com>
Date:	Thu, 14 Apr 2016 17:04:57 -0700
From:	Lee Duncan <lduncan@...e.com>
To:	Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org,
	nab@...ux-iscsi.org, target-devel@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hch@...radead.org,
	agrover@...hat.com, jxm@...iant.com
Subject: Re: [PATCHv2 1/2] target: make target db location configurable

On 04/13/2016 11:10 PM, Hannes Reinecke wrote:
> On 04/13/2016 10:25 PM, Lee Duncan wrote:
>> This commit adds the read-write attribute "dbroot",
>> in the top-level CONFIGFS (core) target directory,
>> normally /sys/kernel/config/target. This attribute
>> defaults to "/var/target" but can be changed by
>> writing a new pathname string to it. Changing this
>> attribute is only allowed when no fabric drivers
>> are loaded and the supplied value specifies an
>> existing directory.
>>
>> Target modules that care about the target database
>> root directory will be modified to use this
>> attribute in a future commit.
>>
>> Signed-off-by: Lee Duncan <lduncan@...e.com>
>> ---
>>  drivers/target/target_core_configfs.c | 51 +++++++++++++++++++++++++++++++++++
>>  drivers/target/target_core_internal.h |  6 +++++
>>  2 files changed, 57 insertions(+)
>>
>> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
>> index 713c63d9681b..bfedbd92b77f 100644
>> --- a/drivers/target/target_core_configfs.c
>> +++ b/drivers/target/target_core_configfs.c
>> @@ -99,6 +99,56 @@ static ssize_t target_core_item_version_show(struct config_item *item,
>>  
>>  CONFIGFS_ATTR_RO(target_core_item_, version);
>>  
>> +char db_root[DB_ROOT_LEN] = DB_ROOT_DEFAULT;
>> +static char db_root_stage[DB_ROOT_LEN];
>> +
>> +static ssize_t target_core_item_dbroot_show(struct config_item *item,
>> +					    char *page)
>> +{
>> +	return sprintf(page, "%s\n", db_root);
>> +}
>> +
>> +static ssize_t target_core_item_dbroot_store(struct config_item *item,
>> +					const char *page, size_t count)
>> +{
>> +	ssize_t read_bytes;
>> +	struct file *fp;
>> +
>> +	if (!list_empty(&g_tf_list)) {
>> +		pr_err("db_root: cannot be changed: target drivers registered");
>> +		return -EINVAL;
>> +	}
> Locking?

Doh. I will resubmit with locking shortly.

> 
> Cheers,
> 
> Hannes
> 

-- 
Lee Duncan