linux-kernel - [PATCH] nfs: make nfs_initialise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1460736139-482-1-git-send-email-dvlasenk@redhat.com>
Date:	Fri, 15 Apr 2016 18:02:19 +0200
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Trond Myklebust <trond.myklebust@...marydata.com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	David Howells <dhowells@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] nfs: make nfs_initialise_sb() static and deinline it

nfs_initialise_sb() is only used in fs/nfs/super.c, no need to be global.

superblock init is not a performance-critical operation, no need to inline.
It compiles to 220 bytes and has two callsites.

   text	     data      bss       dec     hex filename
95903714 20860256 35991552 152755522 91add42 vmlinux_before
95903330 20860256 35991552 152755138 91adbc2 vmlinux

Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
CC: Trond Myklebust <trond.myklebust@...marydata.com>
CC: David Howells <dhowells@...hat.com>
CC: Al Viro <viro@...iv.linux.org.uk>
CC: linux-fsdevel@...r.kernel.org
CC: linux-kernel@...r.kernel.org
---
 fs/nfs/internal.h | 1 -
 fs/nfs/super.c    | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index f1d1d2c..ae235bb 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -393,7 +393,6 @@ extern struct file_system_type nfs4_referral_fs_type;
 bool nfs_auth_info_match(const struct nfs_auth_info *, rpc_authflavor_t);
 struct dentry *nfs_try_mount(int, const char *, struct nfs_mount_info *,
 			struct nfs_subversion *);
-void nfs_initialise_sb(struct super_block *);
 int nfs_set_sb_security(struct super_block *, struct dentry *, struct nfs_mount_info *);
 int nfs_clone_sb_security(struct super_block *, struct dentry *, struct nfs_mount_info *);
 struct dentry *nfs_fs_mount_common(struct nfs_server *, int, const char *,
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index f126828..215277b 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2281,7 +2281,7 @@ EXPORT_SYMBOL_GPL(nfs_remount);
 /*
  * Initialise the common bits of the superblock
  */
-inline void nfs_initialise_sb(struct super_block *sb)
+static void nfs_initialise_sb(struct super_block *sb)
 {
 	struct nfs_server *server = NFS_SB(sb);
 
-- 
1.8.1.4