linux-kernel - Re: [PATCH] drm: panel: simple-panel: set appropriate mode type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57111115.8020509@atmel.com>
Date:	Fri, 15 Apr 2016 18:04:37 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Thierry Reding <thierry.reding@...il.com>,
	<linux-kernel@...r.kernel.org>
CC:	<dri-devel@...ts.freedesktop.org>, David Airlie <airlied@...ux.ie>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Subject: Re: [PATCH] drm: panel: simple-panel: set appropriate mode type

Le 28/05/2015 16:25, Boris Brezillon a écrit :
> Hi Thierry,
> 
> Could you have a look at this patch (a.k.a. ping) ?

It's been a long time and... It seems that this patch doesn't apply
anymore but:

Reviewed-by: Nicolas Ferre <nicolas.ferre@...el.com>

So, I'm updating it and resending right now.

Bye,

> On Thu, 30 Apr 2015 16:39:30 +0200
> Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:
> 
>> All modes exposed by simple panels should be tagged as driver defined
>> modes.
>> Moreover, if a panel supports only one mode, this mode is obviously the
>> preferred one.
>>
>> Doing this also fix a problem occurring when a 'video=' parameter is passed
>> on the kernel cmdline. In some cases the user provided mode is preferred
>> over the simple panel ones, which might result in unpredictable behavior.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
>> ---
>>  drivers/gpu/drm/panel/panel-simple.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index d14b904..95ae390 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -111,6 +111,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
>>  			continue;
>>  		}
>>  
>> +		mode->type |= DRM_MODE_TYPE_DRIVER;
>> +		if (panel->desc->num_modes == 1)
>> +			mode->type |= DRM_MODE_TYPE_PREFERRED;
>> +
>>  		drm_display_mode_from_videomode(&vm, mode);
>>  
>>  		drm_mode_probed_add(connector, mode);
>> @@ -127,6 +131,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
>>  			continue;
>>  		}
>>  
>> +		mode->type |= DRM_MODE_TYPE_DRIVER;
>> +		if (panel->desc->num_modes == 1)
>> +			mode->type |= DRM_MODE_TYPE_PREFERRED;
>> +
>>  		drm_mode_set_name(mode);
>>  
>>  		drm_mode_probed_add(connector, mode);
> 
> 
> 


-- 
Nicolas Ferre