| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1460739631.3012.5.camel@intel.com>
Date: Fri, 15 Apr 2016 17:00:31 +0000
From: "Verma, Vishal L" <vishal.l.verma@...el.com>
To: "Williams, Dan J" <dan.j.williams@...el.com>,
"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libnvdimm, btt: add btt startup debug
On Thu, 2016-04-14 at 19:40 -0700, Dan Williams wrote:
> Report the reason for btt probe failures when debug is enabled.
>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
> drivers/nvdimm/btt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reveiwed-by: Vishal Verma <Vishal.l.verma@...el.com>
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index cc9fafed9362..68a7c3c1eed9 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct
> nd_namespace_common *ndns)
> struct btt *btt;
> size_t rawsize;
>
> - if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
> + if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
> + dev_dbg(&nd_btt->dev, "incomplete btt
> configuration\n");
> return -ENODEV;
> + }
>
> rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
> if (rawsize < ARENA_MIN_SIZE) {
> + dev_dbg(&nd_btt->dev, "%s must be at least %ld
> bytes\n",
> + dev_name(&ndns->dev), ARENA_MIN_SIZE
> + SZ_4K);
> return -ENXIO;
> }
> nd_region = to_nd_region(nd_btt->dev.parent);
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@...ts.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
Powered by blists - more mailing lists