linux-kernel - Re: [PATCH v10 4/5] tpm: Initialize TPM and get durations and timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160415171846.GB21359@obsidianresearch.com>
Date:	Fri, 15 Apr 2016 11:18:46 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:	tpmdd-devel@...ts.sourceforge.net, jarkko.sakkinen@...ux.intel.com,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-api@...r.kernel.org
Subject: Re: [PATCH v10 4/5] tpm: Initialize TPM and get durations and
 timeouts

On Fri, Apr 15, 2016 at 09:50:15AM -0400, Stefan Berger wrote:

> @@ -69,12 +73,19 @@ static ssize_t vtpm_proxy_fops_read(struct file *filp, char __user *buf,
>  	size_t len;
>  	int sig, rc;
>  
> -	sig = wait_event_interruptible(proxy_dev->wq, proxy_dev->req_len != 0);
> +	sig = wait_event_interruptible(proxy_dev->wq,
> +		proxy_dev->req_len != 0 ||
> +		!(proxy_dev->state & STATE_OPENED_FLAG));
>  	if (sig)
>  		return -EINTR;

This hunk and related doesn't look like it belongs in this patch?

Suggest just merging this into the prior patch and be done with it, not
really any reason to have two patches anymore.

I think everything that was brought up is taken care of now..

One last read through..

> static int vtpm_proxy_tpm_op_recv(struct tpm_chip *chip, u8 *buf, size_t count)
> {
>	struct proxy_dev *proxy_dev = dev_get_drvdata(&chip->dev);
>	if (!proxy_dev)
>		return -EIO;

Is that actually possible? It shouldn't be. If not please drop it an
related.

For both:
Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

Jason