linux-kernel - Re: [PATCH] fujitsu-laptop: Support radio LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 15:03:33 +0930
From:	Jonathan Woithe <jwoithe@...t42.net>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Micha?? K??pie?? <kernel@...pniu.pl>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fujitsu-laptop: Support radio LED

On Thu, Apr 14, 2016 at 09:42:55PM -0700, Darren Hart wrote:
> > Signed-off-by: MichaÅ KÄpieÅ <kernel@...pniu.pl>
> 
> Jonathan, please check your character set, a few mangled characters here
> which I have to fix up to use.  UTF-8 seems to work reliably.

Sorry about that.  Normally UTF-8 stuff goes through just fine so I'm not sure
what happened there.  I'll admit I've never touched the default mutt charset
settings though so perhaps there's a corner case that's not being handled. 
I'll look into it.

> > Acked-by: Jonathan Woithe <jwoithe@...t42.net>
> > 
> > MichaÅ hasn't indicated that a revised patch is in the works so I'm fine if
> > you proceed with the one below.  I've selected the relevant parts of his
> > preamble for inclusion in the commit message, but feel free to edit further
> > to your taste.
> 
> Yeah, tough call, some guess work involved here, and where we are
> uncertain, we should document it.  I don't think we need to include bits
> about uncertain future plans or speculation on how things might be done. 
> Keep it to what this patch does and any qualifiers a developer should be
> aware of.

I agree.  Also note that a followup post from the original submitter
indicated they were happy to go with what I proposed.

> I've made a couple cosmetic changes and queued to for-next. Please review
> and let me know if you have any concerns.

Sure.  Pardon my ignorance of such things, but what is the most
straight-forward way to review the queued commit (preferrably without
cloning an entire kernel git repo)?

jonathan