linux-kernel - Re: [PATCH] pci: xgene: Add ECAM fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6597458.plyKBtcpp4@wuerfel>
Date:	Sat, 16 Apr 2016 09:43:40 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Duc Dang <dhdang@....com>, Feng Kan <fkan@....com>,
	Tomasz Nowicki <tn@...ihalf.com>,
	Mark Salter <msalter@...hat.com>, patches <patches@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Loc Ho <lho@....com>, linux-pci@...r.kernel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Tanmay Inamdar <tinamdar@....com>
Subject: Re: [PATCH] pci: xgene: Add ECAM fixups

On Friday 15 April 2016 14:30:56 Duc Dang wrote:
> On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann <arnd@...db.de> wrote:
> > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote:
> >> X-Gene PCIe controller does not fully support ECAM.
> >> This patch adds required ECAM fixup to allow X-Gene
> >> PCIe controller to be functional in ACPI boot mode.
> >>
> >> This patch is based on the original work of
> >> Mark Salter <msalter@...hat.com> and depends on
> >> Tomasz's PCIe ACPI series:
> >> https://lkml.org/lkml/2016/2/4/646
> >>
> >> Signed-off-by: Duc Dang <dhdang@....com>
> >> ---
> >
> > This really has nothing to do with the PCI host device driver, please
> > keep it in a separate file in drivers/acpi/.
> 
> Hi Arnd,
> 
> With Tomasz latest PCIe ACPI series
> (https://lkml.org/lkml/2016/4/15/594), do you think it still better to
> keep the ACPI ECAM fixup code in a separate file in drivers/acpi
> directory?

Yes, I made the same comment for the cavium PCI workaround in that
series.

	Arnd