linux-kernel - Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Apr 2016 10:11:57 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	linux-mtd@...ts.infradead.org, Richard Weinberger <richard@....at>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field

On Sat, 16 Apr 2016 09:58:07 +0200
Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:

> On Fri, 15 Apr 2016 21:54:10 +0200
> Rafał Miłecki <zajec5@...il.com> wrote:
> 
> > Now we have all drivers properly setting this new field we can start
> > using it and proceed with deprecating NAND_ECC_SOFT_BCH.
> > 
> > Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> > ---
> >  drivers/mtd/nand/nand_base.c | 98 ++++++++++++++++++++++++--------------------
> >  1 file changed, 53 insertions(+), 45 deletions(-)
> > 

[...]

> > @@ -4248,51 +4248,59 @@ int nand_scan_tail(struct mtd_info *mtd)
> >  		ecc->algo = NAND_ECC_HAMMING;
> >  
> >  	case NAND_ECC_SOFT:
> > -		ecc->calculate = nand_calculate_ecc;
> > -		ecc->correct = nand_correct_data;
> > -		ecc->read_page = nand_read_page_swecc;
> > -		ecc->read_subpage = nand_read_subpage;
> > -		ecc->write_page = nand_write_page_swecc;
> > -		ecc->read_page_raw = nand_read_page_raw;
> > -		ecc->write_page_raw = nand_write_page_raw;
> > -		ecc->read_oob = nand_read_oob_std;
> > -		ecc->write_oob = nand_write_oob_std;
> > -		if (!ecc->size)
> > -			ecc->size = 256;
> > -		ecc->bytes = 3;
> > -		ecc->strength = 1;
> > -		break;
> > -
> >  	case NAND_ECC_SOFT_BCH:
> 
> Shouldn't we drop this case?

Nevermind, I see you're dropping it in the last patch.


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com